Search Linux Wireless

Re: [PATCHv2 00/21] cw1200: ST-Ericsson cw1200 wlan device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 05, 2012 at 01:16:31PM -0500, Steev Klimaszewski wrote:
> On Thu, May 31, 2012 at 12:45 AM, Janusz Dziedzic
> <janusz.dziedzic@xxxxxxxxx> wrote:
> > 2012/5/9 Dmitry Tarnyagin <abi.dmitryt@xxxxxxxxx>:
> >> Hi,
> >>
> >> Could you please check status of this submission? It looks like review
> >> was passed, but patchset was not taken in. Have I done something
> >> wrong?
> >>
> >
> > Any news?
> >
> >
> > BR
> > Janusz
> > --
> 
> Any news on this?

Sorry, I kinda lost track of this.  I guess I was expecting a repost,
including Bob Copeland's patches and something to address the endian
issues mentioned by Kevin Groenevel.  Was anyone planning to address
those concerns?  Also, I'm not sure that bit about needing custom
SDD files was fully addressed?

On top of that, there were some style quirks that I was hoping
someone could address.  There were "if 0" blocks in the code, which
is rather questionable.  Was anyone planning to remove them?  Also,
the block comment formats seemed a little random.  In particular, the
single-line "/* ********* */" thing looks a bit funny.  Perhaps that
isn't the worst thing ever but if you are going to respin anyway than
I'd prefer if you just deleted them.

There was also talk of a mac80211 patch needed to fix a bug observed
with the driver as posted?  Has that mac80211 fix been posted and
merged?  If not, when will we see it?

So anyway, it seems like a repost of the current version (i.e. with
Bob's fixes, etc) is in order?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux