On 07/05/2012 03:24 PM, Ivan Ivanich wrote:
On Четверг, 05-июл-2012 15:16:00 Larry Finger wrote:
Ivan,
The following patch is suggested by the code-analysis tool cppcheck as the
test is always false. As it will not affect STA usage, I have no way to
test the change. Could you please do so?
Thanks,
Larry
Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
+++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
@@ -1097,7 +1097,7 @@ static int _rtl92ce_set_media_status(str
rtl_write_byte(rtlpriv, (MSR), bt_msr);
rtlpriv->cfg->ops->led_control(hw, ledaction);
- if ((bt_msr & 0xfc) == MSR_AP)
+ if ((bt_msr & 0x03) == MSR_AP)
rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
else
rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
Yes, compiling now, for some reason it doesn't apply cleanyl so I manualy
changed this line.
And what exactly I should test?
Does it affect operation in AP mode? Before this change, the code always wrote
0x66 to the register. Now it seems that it will write 0 if in AP mode. As I have
no idea what that register does, I do not know what effect the change will have.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
