On Mon, 2012-07-02 at 17:50 -0500, Larry Finger wrote: > On 07/02/2012 12:38 PM, Johannes Berg wrote: > > > >>> I'm not sure which fix is correct though. Should we have software QoS > >>> queues for these drivers, but we'll never use them? Then this would > >>> work: > >>> http://p.sipsolutions.net/e015bf7db9a05887.txt > >>> > >>> Or we could change the enable code path. Hmm. > >> > >> That patch does prevent the oops. I was not able to make a connection with the > >> device, but I just acquired it, and I'm not sure of its quality, or that of the > >> driver. > > > > I don't think that device works today -- IIRC it requires the BSSID > > before authentication and that wasn't possible before the auth redesign. > > > >> It does scan OK, and I think the patch is OK. I'll do more tests with > >> b43legacy later as the machine with that iface is busy. I will also test b43 on > >> the PPC using the open-source firmware. > >> > >> Although you may want to change the enable code path, some patch will be needed > >> to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" > >> for me. > > > > Thanks. Could you try this patch instead? I think it makes more sense. > > > > http://p.sipsolutions.net/c3e9b814a409ca11.txt > > That one fails and gives the oops in __netif_schedule. Hmmm, that's odd. I'll try to reproduce this to be able to track it better. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
