On Tue, 2012-07-03 at 13:53 +0300, Dan Carpenter wrote:
> Hello Vladimir Kondratiev,
>
> The patch 3a0c52a6d82c: "cfg80211: add 802.11ad (60gHz band) support"
> from Jul 2, 2012, leads to the following warning:
> drivers/net/wireless/mac80211_hwsim.c:1841 init_mac80211_hwsim()
> warn: buffer overflow 'data->bands' 2 <= 2
>
> drivers/net/wireless/mac80211_hwsim.c
> 1839
> 1840 for (band = IEEE80211_BAND_2GHZ; band < IEEE80211_NUM_BANDS; band++) {
> ^^^^^^^^^^^^^^^^^^^
> We raised IEEE80211_NUM_BANDS to 3.
>
> 1841 struct ieee80211_supported_band *sband = &data->bands[band];
> ^^^^^^^^^^^
> This only has 2 elements still.
>
> 1842 switch (band) {
> 1843 case IEEE80211_BAND_2GHZ:
>
> It causes a bogus dereference later.
Thanks Dan!
Is this one of your non-default tests? I think I ran smatch on this, but
it might be old. Anyway, I'll commit this fix:
http://p.sipsolutions.net/a1c40eea7e33541b.txt
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
