On Mon, 2012-07-02 at 17:22 +0300, Arik Nemtsov wrote:
> enum ieee80211_band {
> IEEE80211_BAND_2GHZ = NL80211_BAND_2GHZ,
> IEEE80211_BAND_5GHZ = NL80211_BAND_5GHZ,
>
> /* keep last */
> IEEE80211_NUM_BANDS
> };
>
> If the 60Ghz band goes here as well, IEEE80211_NUM_BANDS will be
> incremented.
Yes, this happened.
> I'm guessing this can be problematic for a lot of drivers
> that use this value more or less blindly (and pass indices to FW etc).
> At least the wlcore driver will be impacted.
>
> So this probably should be added, but maybe keep IEEE80211_NUM_BANDS
> the same for legacy reasons?
Can't do that, it's used for array sizing etc.
It looks like your driver may crash as it accesses bands[x] for all
possible values of x ... might want to fix that soon as I've applied
these patches :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
