Search Linux Wireless

Re: [PATCH v2 11/18] brcmsmac: remove some unnessessacry casts and void pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hauke,

On Sat, Jun 30, 2012 at 11:16 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote:
> Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---
>  drivers/net/wireless/brcm80211/brcmsmac/main.c |   11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index 478b374..8bad8b6 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -4241,10 +4240,8 @@ static void brcms_b_watchdog(void *arg)
>  }
>
>  /* common watchdog code */
> -static void brcms_c_watchdog(void *arg)
> +static void brcms_c_watchdog(struct brcms_c_info *wlc)
>  {
> -       struct brcms_c_info *wlc = (struct brcms_c_info *) arg;
> -
>         BCMMSG(wlc->wiphy, "wl%d\n", wlc->pub->unit);
>
>         if (!wlc->pub->up)
> @@ -4284,7 +4281,9 @@ static void brcms_c_watchdog(void *arg)
>
>  static void brcms_c_watchdog_by_timer(void *arg)
>  {
> -       brcms_c_watchdog(arg);
> +       struct brcms_c_info *wlc = (struct brcms_c_info *) arg;
> +
> +       brcms_c_watchdog(wlc);

You remove 2 cases of this pattern in your patch then add one. Why?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux