On Thursday, June 28, 2012 08:04:24 PM Johannes Berg wrote:
> On Thu, 2012-06-28 at 14:16 +0300, Vladimir Kondratiev wrote:
> > + /*
> > + * on 60gHz band, there are no legacy rates, so
> > + * n_bitrates is 0
> > + */
> > + if (WARN_ON((band != IEEE80211_BAND_60GHZ) &&
> > + !sband->n_bitrates))
> >
> > return -EINVAL;
>
> Please fix indentation.
>
> johannes
I am confused a bit. What is "proper" identation for this case
(wrapped expression)?
Immediately following code use same identation (4 spaces).
if (cfg80211_disable_40mhz_24ghz &&
band == IEEE80211_BAND_2GHZ &&
sband->ht_cap.ht_supported) {
sband->ht_cap.cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
sband->ht_cap.cap &= ~IEEE80211_HT_CAP_SGI_40;
}
Should I ident line containing (see above):
!sband->n_bitrates))
with:
- 4 spaces as next code fragment,
- one tab (same level as 'return')
- 2 tabs (one level more then 'return')
- other (what?)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
