Johannes Berg schrieb: > On Fri, 2012-06-29 at 05:56 -0700, Thomas Huehn wrote: >> brcmsmac uses info->control.sta while doing ampdu aggregation. This patch >> changes the usage of the structure info->control.sta, as it is going to be >> removed soon from struct ieee80211_tx_info. This patch is a pre-requisit in >> order to add transmission power control (TPC) to the mac80211 subsystem. >> >> Suggested-by: Felix Fietkau <nbd@xxxxxxxxxxx> >> Signed-off-by: Thomas Huehn <thomas@xxxxxxxxxxxxxxxxxxxxxxx> >> --- >> Change sequence of overwriting data. Thx to Johannes. > > >> @@ -665,7 +665,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi, >> u8 plcp0, plcp3, is40, sgi; >> struct ieee80211_sta *sta; >> >> - sta = tx_info->control.sta; >> + sta = tx_info->rate_driver_data[0]; > > Are you sure it actually works now? >From locking at the code, sta is never used after it gets overridden. The brcmsmac driver does not use the vif pointer at all. I asked Felix to double check as I do not have a Broadcom device over here. Bye Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
