Search Linux Wireless

Re: [PATCH] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Johannes Berg schrieb:

> On Thu, 2012-06-28 at 21:15 -0700, Thomas Huehn wrote:
>> @@ -267,7 +267,9 @@ static void brcms_set_basic_rate(struct brcm_rateset *rs, u16 rate, bool is_br)
>>  static void brcms_ops_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
>>  {
>>  	struct brcms_info *wl = hw->priv;
>> +	struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
>>  
>> +	tx_info->rate_driver_data[0] = tx_info->control.sta;
> 
> It seems that brcmsmac doesn't care about anything but the
> tx_info->flags, but it would still seem safer to overwrite the data
> before the function returns, rather than as the first thing?
> 

I will send a version 2.
Thx Johannes for the suggestion.

Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux