Search Linux Wireless

Re: [PATCH] wlcore: implement .flush callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 28, 2012 at 2:25 PM, Eliad Peller <eliad@xxxxxxxxxx> wrote:
> On Thu, Jun 28, 2012 at 2:07 PM, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
>> On 06/27/2012 06:09 PM, Luciano Coelho wrote:
>>> From: Eliad Peller <eliad@xxxxxxxxxx>
>>>
>>> implement the .flush() callback by simply calling wl1271_tx_flush().
>>>
>>> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
>>> Signed-off-by: Luciano Coelho <coelho@xxxxxx>
>>> ---
>>>  drivers/net/wireless/ti/wlcore/main.c |    8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
>>> +static void wlcore_op_flush(struct ieee80211_hw *hw, bool drop)
>>> +{
>>> +     struct wl1271 *wl = hw->priv;
>>> +
>>> +     wl1271_tx_flush(wl);
>>> +}
>>> +
>>
>> So not taking the drop flag into account? Any plan to change that?
>>
> yeah, good point...
> i guess we'll want to add support for the drop flag as well.
>
> Luca - you can either drop this patch, or apply it for now and i'll
> send another patch later on.

Currently we drop all the packets if we can't flush them within a
reasonable time. We always do this right now. I think that's good
enough?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux