Johannes Berg wrote:
On Mon, 2012-06-25 at 08:57 +0200, Michal Kazior wrote:
Johannes Berg wrote:
On Wed, 2012-06-20 at 08:14 +0200, Michal Kazior wrote:
Implements behaviour seen in mac80211. A running
monitor always has a channel - even before
.set_channel. This way we won't break current
behaviour.
I'm a little doubtful about this. Currently, mac80211 will keep the
channel if you set it on say wlan0, your monitor iface gets the same
channel. Then if you remove wlan0, you still have the same channel, but
it seems here this is different now? I'm not sure it matters much, but
it's worth thinking about? Or am I totally misunderstanding this now?
Right. It's not the exact same behaviour. It only guarantees a channel
is always set in monitor mode. We could maybe set the last
monitor-mode-channel seen when starting up monitor-mode again. Would
that be okay?
Yeah I think that's probably fine. Come to think of it, without that
change you always have a channel pointer, but it's not guaranteed to be
programmed into the device? Maybe I'm confused.
The rdev->monitor_channel is set to NULL when monitor mode is disabled
(see `cfg80211: track monitor channel`).
When monitor mode is started the hardware is programmed (and pointer
set) to the first channel found in supported bands (see `cfg80211: set
initial monitor channel`).
--
Pozdrawiam / Best regards, Michal Kazior.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
