On Sat, Jun 23, 2012 at 07:41:35AM +0530, Sujith Manoharan wrote: > David Miller wrote: > > From: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx> > > Date: Sat, 23 Jun 2012 05:05:10 +0530 > > > > > Sujith Manoharan wrote: > > >> John W. Linville wrote: > > >> > Mohammed Shafi Shajakhan (1): > > >> > ath9k_hw: avoid possible infinite loop in ar9003_get_pll_sqsum_dvc > > >> > > >> Um, this commit doesn't really fix anything - the timeout is also > > >> arbitrary. Can you remove this from the 3.5 queue ? Thanks. > > > > > > A review of the patch later, I think it's good. At least there's a > > > WARN_ON_ONCE() to indicate the situation in which the measurement fails. > > > It might come in handy as a debugging aid. > > > > Thanks for wasting our time. > > > > Make these determinations when changes to into John's tree, not > > later when he asks me to pull them into mine. > > The patch was under review: > http://marc.info/?l=linux-wireless&m=134001371002288&w=2 Quibbling over the exact number of iterations for a timeout didn't seem is important as avoiding an endless loop... -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
