On Fri, 2012-06-22 at 17:21 +0200, Johannes Berg wrote: > On Fri, 2012-06-22 at 07:41 -0700, Joe Perches wrote: > > > > > > That doesn't make any sense at > > > > > all, and requires teaching everybody new tricks, so I'm basically > > > > > reverting it for now in favour of pr_info() instead of pr_debug(). > > > > > > > > Why not just add #define DEBUG? > > > > > > I guess that works? > > > > That works. > > Are you sure? It doesn't really seem to work ... > > #if defined(CONFIG_DYNAMIC_DEBUG) > /* dynamic_pr_debug() uses pr_fmt() internally so we don't need it here */ > #define pr_debug(fmt, ...) \ > dynamic_pr_debug(fmt, ##__VA_ARGS__) > #elif defined(DEBUG) > #define pr_debug(fmt, ...) \ > printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) > > > > So basically, if you have CONFIG_DYNAMIC_DEBUG, you *still* need to > enable it with the dynamic debug framework, right? No. In dynamic_debug.h, there's a mechanism to enable all dynamic_pr_debug lines when DEBUG is #defined #if defined DEBUG #define _DPRINTK_FLAGS_DEFAULT _DPRINTK_FLAGS_PRINT #else #define _DPRINTK_FLAGS_DEFAULT 0 #endif -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
