Search Linux Wireless

Re: [PATCH 2/3] ath9k_hw: fix smatch warnings in spur_mitigate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 22, 2012 at 02:57:47PM +0300, Dan Carpenter wrote:
> On Fri, Jun 22, 2012 at 02:44:14PM +0300, Kalle Valo wrote:
> > Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes:
> > 
> > >> > -			qCoff = qCoff & 0x7f;
> > >> > +			qCoff &= 0x7f;
> > >> 
> > >> I'm curious, how does a change like this fix anything? To me it just
> > >> looks same functionality, just a different operator is used. Am I
> > >> missing something?
> > >
> > > Though it doesn't make a difference, somehow it fixes smatch warning.
> > > I agree it is not the right fix.
> > 
> > Ok, maybe it's just that smatch isn't clever enough with the &= operator.
> > Dan?
> 
> Ugh...  I think it's debugging code that leaked into the wild.  I
> will remove that.
>
Thanks Dan. I'll rerun smatch once you pushed the changes.

-Rajkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux