Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes:
> ath9k_get_et_stats() warn: side effect in macro
> 'AWDATA' doing 'i++'
>
> Cc: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx>
[...]
> do { \
> - data[i++] = sc->debug.stats.txstats[PR_QNUM(WME_AC_BE)].elem; \
> - data[i++] = sc->debug.stats.txstats[PR_QNUM(WME_AC_BK)].elem; \
> - data[i++] = sc->debug.stats.txstats[PR_QNUM(WME_AC_VI)].elem; \
> - data[i++] = sc->debug.stats.txstats[PR_QNUM(WME_AC_VO)].elem; \
> + data[i+0] = sc->debug.stats.txstats[PR_QNUM(WME_AC_BE)].elem; \
> + data[i+1] = sc->debug.stats.txstats[PR_QNUM(WME_AC_BK)].elem; \
> + data[i+2] = sc->debug.stats.txstats[PR_QNUM(WME_AC_VI)].elem; \
> + data[i+3] = sc->debug.stats.txstats[PR_QNUM(WME_AC_VO)].elem; \
> + i += 4; \
> } while (0)
I agree with Ben, this is a useless change as the end result is still
the same (the side effect is that i is increased with four). You are
just hiding that from smatch and once smatch is fixed it will warn again
about the same thing.
I recommend fixing this properly so that the macro doesn't have any side
effects.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
