On Fri, 2012-06-22 at 06:47 +0000, Mahesh Palivela wrote: > > [MP] Should I declare another constant for this? > > +#define IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_3895 0 > > Yes I think that would be good > But every VHT capability bitfields value zero has a meaning. > Max_MPDU_len field is 2 bits. 0 - 3895, 1 - 7991, 2 - 11454, 3 - reserved > Supp_ch_width field is 2 bits. 0 - 160 MHz not supp, 1 - 160 MHz supp, 2 - 160/80+80 supp. > My point is should we have constant defines for all of those? Not all, some are truly boolean like IEEE80211_VHT_CAP_TXSTBC which you can turn on and off. I just think that for the ones that aren't really bool because they occupy more than one bit would be worthwhile to list all option? Oh also can you send as [PATCH] soon? :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
