________________________________________
From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx]
Sent: Thursday, June 21, 2012 8:15 PM
To: Mahesh Palivela
Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [RFC v2] cfg80211/mac80211: 802.11ac changes
On Thu, 2012-06-21 at 05:13 +0000, Mahesh Palivela wrote:
> +/**
> + * struct ieee80211_vht_mcs_info - VHT MCS information
> + * @rx_mask: RX mask
> + * @rx_highest: highest supported RX rate. If set represents
> + * the highest supported RX data rate in units of 1 Mbps.
> + * If this field is 0 this value should not be used to
> + * consider the highest RX data rate supported.
> + * @tx_params: TX parameters
those don't seem to match below -- rx_mcs_map, tx_mcs_map and tx_highest
should be there?
[MP] Yes. I missed it. Just sent another patch with correct comments.
> +struct ieee80211_vht_mcs_info {
> + __le16 rx_mcs_map;
> + __le16 rx_highest;
> + __le16 tx_mcs_map;
> + __le16 tx_highest;
> +} __packed;
> + if (supp_vht)
> + local->scan_ies_len += 2 + sizeof(struct ieee80211_vht_capabilities);
that line looks a bit long, but yeah, this is what I was thinking of
before :-)
[MP] Yes. I didn't know that.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
