Sorry, forgot to include Yoni as CC on this one.
On Thu, 2012-06-21 at 17:13 +0300, Luciano Coelho wrote:
> From: Yoni Divinsky <yoni.divinsky@xxxxxx>
>
> The get survey op expects the low level driver to report
> the noise level for a a given channel.
>
> The noise calculated in wlcore is (rssi-snr/2), but since
> the snr reported by the FW is a derivative from the rssi
> this calculation is useless, and should not be reported
> to the user space.
>
> Reporting incorrect noise, results in the wpa_supplicant
> miscalculating the roaming candidate priority, thus causing
> a situation where an AP with a lower rssi level would be
> chosen over a better AP.
>
> Signed-off-by: Yoni Divinsky <yoni.divinsky@xxxxxx>
> Signed-off-by: Luciano Coelho <coelho@xxxxxx>
> ---
> drivers/net/wireless/ti/wlcore/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
> index 3279a94..a7c5e32 100644
> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -4108,16 +4108,13 @@ out:
> static int wl1271_op_get_survey(struct ieee80211_hw *hw, int idx,
> struct survey_info *survey)
> {
> - struct wl1271 *wl = hw->priv;
> struct ieee80211_conf *conf = &hw->conf;
>
> if (idx != 0)
> return -ENOENT;
>
> survey->channel = conf->channel;
> - survey->filled = SURVEY_INFO_NOISE_DBM;
> - survey->noise = wl->noise;
> -
> + survey->filled = 0;
> return 0;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
