On Wed, 2012-06-20 at 16:22 +0300, Goldenshtein, Victor wrote: > On Wed, Jun 20, 2012 at 11:15 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Wed, 2012-06-20 at 09:32 +0300, Victor Goldenshtein wrote: > > > >> + trace_drv_get_rssi(local, sdata); > >> + ret = local->ops->get_rssi(&local->hw, &sdata->vif, sta, rssi_dbm); > >> + trace_drv_return_int(local, ret); > > > > Where are you tracing the sta? > > > > We talked about print sta address with "local_sdata_addr_evt" event > macro, the output looks like this: > > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > iw-1394 [000] ...1 1083.713867: drv_get_rssi: > phy0 vif:wlan0(2) addr:08:00:28:cc:65:43 > iw-1394 [000] ...1 1083.729736: drv_return_int: phy0 - 0 That's not the STA address, that's the VIF address. > > And why not trace the value returned in *rssi_dbm? > > > > Is it really required ? there are various driver-ops which are "get > stuff" without printing them in the tracer. It'd be nice to fix all the ones, but I can't make you do that :-) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
