Search Linux Wireless

Re: [PATCH v2] mac80211: initialize sta pointer to avoid false-positive warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-06-20 at 10:52 +0200, Johannes Berg wrote:
> On Mon, 2012-06-18 at 15:52 +0300, Luciano Coelho wrote:
> > Some compilers (eg. gcc 4.4.1 for ARM) report a false positive warning
> > in mlme.c:
> > 
> > net/mac80211/mlme.c: In function 'ieee80211_prep_connection':
> > net/mac80211/mlme.c:3035: warning: 'sta' may be used uninitialized in this function
> > 
> > This is a false positive because the place where 'sta' is used is
> > inside an if with the same condition of where it is set:
> 
> I still think it's a workaround, but what the hell ... applied.

Yes, it is a workaround, but a lean one.  :) And I think after your
suggestion it makes the code slightly more readable.

Thanks for applying!

BTW, when you say you applied, does it mean you have pushed to your
tree? We want to remove some of our mac80211 patches from our internal
trees and "inherit" them from upstream instead, that's why I'm
asking. ;)

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux