Hi Will, > I am sending along 2 patches to add support for user space applications > to register for authentication frames on adhoc interfaces. These are > revisions to a previous patch that I submitted to accomplish the same > thing. Thanks. > Patch 1/2 adds a cfg80211_mgmt_reg_match function to cfg80211 to > check whether a user space application is registered for a particular > type of management frame rx'd on a particular device. The new function > is very similar to cfg80211_rx_mgmt. cfg80211_rx_mgmt could not be > reused because of its side-effect of transmitting the "query" frames to > the registered userspace applications. This patch modifies the > documentation for cfg80211_rx_mgmt to reflect that. I think this isn't needed: if you look at mac80211/cfg.c, there's a handler called ieee80211_mgmt_frame_register() where cfg80211 tells mac80211 when a handler is registered/unregistered. mac80211 could just keep track (for IBSS type interfaces) all by itself, and then just needs to check some flag/variable instead of calling a function. > Patch 2/2 sets the necessary flags to allow userspace > applications to register for authentication frames on adhoc interfaces. > It also adds a check to make sure that "open" authentication frames are > not sent when a user space application is registered for authentication > frames. Makes sense. I'll need to check if you caught all conditions, maybe Antonio can help out. > As I've said before, I'm still new to this process so I look forward to > your feedback on improving. There's not a lot of room for improvement :-) A small detail: the first patch should have been labelled only "cfg80211" and the second only "mac80211". Also, if you could send the patches (1/2 and 2/2) as a reply to the cover letter (0/2) that helps keep the series together due to threading. With git send-email you can instruct it to do that, but it didn't look like you used it. Thanks! johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
