Felix Fietkau wrote: > Hm, good point. Maybe use u32 then. Either way, the lock in this patch > does almost nothing to protect against race conditions, since it doesn't > apply to other places in the code that change sc->sc_flags. > Maybe we should change that entire thing to just use set_bit/test_bit > instead. That is because the locking for all the other flags has to be cleaned up. Especially the powersave/beacon flags, and the usage of other locks are hazy (sc_pcu_lock etc.). We can clean all of them, but I think it will be an involved process - and the watchdog race is a crippling issue as far as general usage is concerned. Disconnects occur in regular usage quite frequently, breaking stress tests. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html