On Sat, May 26, 2012 at 12:31:36AM +0200, Arend van Spriel wrote: > On 04/16/2012 10:17 PM, Seth Forshee wrote: > > Hi Arnd, > > You missed an 'e' ;-) Oops! My apologies :) > > Here's the latest update to the brcmsmac regulatory rework that I've > > been working on. I've broken it up into a series of smaller patches, > > cleaned things up, and finished what changes I can with the information > > available to me. > > It took a while. There were some discussions and we agreed that your > changes establish a better integration with the regulatory framework. > There are some concerns about the content of the crda database, but that > is another thing outside the scope of your patches. Great! > > I've attempted to maintain the same high-level behavior that the > > brcmsmac internal regulatory support currently enforces. > > Appreciated. We can add/change in subsequent patches. I collected review > comments internally including mine. I will provide them in response to > each individual patch. I've looked over the comments, and I agree with most of them. I'll respond to each individually. > General comment: you should run 'checkpatch.pl --strict' script over the > patches. I came across several issues that will probably be flagged by it. Yeah, I didn't bother with it for the RFC patches since I just wanted to ensure that I had buy-in from you guys on the changes in general. I've already got a few things cleaned up locally, and I'll run everything through checkpatch before I send them again. Thanks, Seth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
