On Thu, 2012-05-17 at 11:28 -0700, Bing Zhao wrote: > > Don't touch it. I knew I should have hidden these fields from driver > > view, but it wasn't easily possible. > > > > If you're using the API wrong then you should fix that instead. In > > particular, you should only call cfg80211_ibss_joined() when you > > actually know the BSSID of the IBSS you've joined. You can't possibly > > know this at this point since you can't even have scanned for peers yet. > > In .join_ibss handler, mwifiex driver sends a command to firmware to start/join an IBSS network. > This command is a synchronous call. When the command response comes > back we have started/joined it successfully, otherwise an error code > will be returned. However, we are still inside .join_ibss handler at > this moment. Calling cfg80211_ibss_joined() gives us the warning > because ssid_len hasn't been set by cfg80211 yet. Hmm. Interesting, because I would think that could potentially take quite a while? It's interesting though because it points out that even if you do call it asynchronously, there's no guarantee that it actually happens before the function call returns. Maybe we should just move the assignment in cfg80211 instead? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
