On Mon, 2012-05-14 at 11:03 -0700, Pedersen, Thomas wrote: > On Mon, May 14, 2012 at 10:56:59AM -0700, Joe Perches wrote: > > On Mon, 2012-05-14 at 10:47 -0700, Thomas Pedersen wrote: > > > Enable enhanced bmiss detection if the firmware supports it. This > > > feature is only enabled on some firmwares since it comes with a power > > > cost. > > [] > > > diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c > > [] > > > @@ -2614,6 +2619,30 @@ static int ath6kl_set_channel(struct wiphy *wiphy, struct net_device *dev, > > > return 0; > > > } > > > > > > +void ath6kl_cfg80211_sta_bmiss_enhance(struct ath6kl_vif *vif, bool enable) [] > > Why 2 messages when 1 message might do? > > > > err = ath6kl_wmi_sta_bmiss_enhance_cmd(vif->ar->wmi, > > vif->fw_vif_idx, enable); > > ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, > > "%s enhanced fw bmiss detection: %s\n", > > enable ? "enable" : "disable", > > err ? "OK" : "failed"); > > OK that seems nicer. Should we still print the error code, or maybe it > doesn't really matter? Hi Thomas. That's up to you. I don't know the code at all. btw: the err ?: output is badly reversed in my example. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
