Search Linux Wireless

Re: [PATCH] ath9k: Support ethtool getstats api.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08/2012 12:55 AM, Kalle Valo wrote:
Ben Greear<greearb@xxxxxxxxxxxxxxx>  writes:

No, there is a check later that does a BUG_ON if our
we have screwed up the indexing of the stats.

Please, no BUG_ON() calls in wifi drivers. They just make users life
miserable. WARN_ON() with a safe bailout is enough.

Ok, I can change that.

The reason I left it at BUG_ON before is because a mistake
here could easily be a buffer overflow, so I wanted to make
sure it was caught in development.

But, a warn-on should be sufficient.

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux