Hi, Johannes If the destination address is not broadcast frame, the number of forwarded unicast frame is increased. And the other way round. Not correct? + if (!is_multicast_ether_addr(da)) + ifmsh->mshstats.fwded_unicast++; + else + ifmsh->mshstats.fwded_mcast++; Regards, Chun-Yeow On Mon, May 7, 2012 at 3:43 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2012-05-04 at 12:36 +0800, Chun-Yeow Yeoh wrote: >> Forwarded PREQ is either unicast or multicast. The appropriate counters >> should be incremented accordingly. >> >> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx> >> --- >> net/mac80211/mesh_hwmp.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c >> index 503016f..f0695e5 100644 >> --- a/net/mac80211/mesh_hwmp.c >> +++ b/net/mac80211/mesh_hwmp.c >> @@ -603,7 +603,10 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata, >> hopcount, ttl, cpu_to_le32(lifetime), >> cpu_to_le32(metric), cpu_to_le32(preq_id), >> sdata); >> - ifmsh->mshstats.fwded_mcast++; >> + if (da != broadcast_addr) > > In addition to what Javier said. Err. Think about this comparison again. > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
