Search Linux Wireless

Re: [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Javier

Will do.

Chun-Yeow

On Fri, May 4, 2012 at 2:17 PM, Javier Cardona <javier@xxxxxxxxxxx> wrote:
> Hi Yeoh,
>
>
> On Friday, May 4, 2012, Chun-Yeow Yeoh wrote:
>>
>> Forwarded PREQ is either unicast or multicast. The appropriate counters
>> should be incremented accordingly.
>>
>> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx>
>> ---
>>  net/mac80211/mesh_hwmp.c |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
>> index 503016f..f0695e5 100644
>> --- a/net/mac80211/mesh_hwmp.c
>> +++ b/net/mac80211/mesh_hwmp.c
>> @@ -603,7 +603,10 @@ static void hwmp_preq_frame_process(struct
>> ieee80211_sub_if_data *sdata,
>>                                hopcount, ttl, cpu_to_le32(lifetime),
>>                                cpu_to_le32(metric), cpu_to_le32(preq_id),
>>                                sdata);
>> -               ifmsh->mshstats.fwded_mcast++;
>> +               if (da != broadcast_addr)
>> +                       ifmsh->mshstats.fwded_unicast++;
>> +               else
>> +                       ifmsh->mshstats.fwded_mcast++;
>>                ifmsh->mshstats.fwded_frames++;
>>        }
>>  }
>> --
>> 1.7.0.4
>
>
> I think you should check for multicast, not just bcast.  And use the
> existing helper function to do so.
>
> Javier
>
>
> --
> Javier Cardona
> cozybit Inc.
> http://www.cozybit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux