On Thu, May 3, 2012 at 12:39 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2012-04-30 at 14:20 -0700, Ashok Nagarajan wrote:
>
>> +/** mesh_set_ht_prot_mode - set correct HT protection mode
>
> I think you need a newline before the function name, but this isn't
> really valid kernel-doc anyway so please just don't use **
>
Noted.
>> + *
>> + * Section 9.23.3.5 of IEEE 80211s standard
>
> There's no 80211s standard. 802.11s is an amendment, please correct the
> reference to the -2012 version.
>
Noted.
>> + rcu_read_lock();
>> + list_for_each_entry_rcu(sta, &local->sta_list, list) {
>> + if (sdata == sta->sdata &&
>> + sta->plink_state == NL80211_PLINK_ESTAB) {
>
> there would be less indentation if you'd add a continue for the mismatch
> cases :-)
>
> johannes
>
Thank you,
Ashok
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
