On Sun, 2012-04-22 at 22:57 +0200, Jesper Juhl wrote: > On Sun, 22 Apr 2012, Jesper Juhl wrote: > > > We currently do this: > > > > int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif) > > ... > > struct wl12xx_arp_rsp_template *tmpl; > > struct ieee80211_hdr_3addr *hdr; > > ... > > tmpl = (struct wl12xx_arp_rsp_template *)skb_put(skb, sizeof(*tmpl)); > > memset(tmpl, 0, sizeof(tmpl)); > > ... > > hdr = (struct ieee80211_hdr_3addr *)skb_push(skb, sizeof(*hdr)); > > memset(hdr, 0, sizeof(*hdr)); > > ... > > > > I believe we want to set the entire structures to 0 with those > > memset() calls, not just zero the initial part of them (size of the > > pointer bytes). > > > > Sorry, I accidentally copied that code from the fixed version. The above > should read: > > > We currently do this: > > int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif) > ... > struct wl12xx_arp_rsp_template *tmpl; > struct ieee80211_hdr_3addr *hdr; > ... > tmpl = (struct wl12xx_arp_rsp_template *)skb_put(skb, sizeof(*tmpl)); > memset(tmpl, 0, sizeof(tmpl)); > ... > hdr = (struct ieee80211_hdr_3addr *)skb_push(skb, sizeof(*hdr)); > memset(hdr, 0, sizeof(hdr)); > ... > > I believe we want to set the entire structures to 0 with those > memset() calls, not just zero the initial part of them (size of the > pointer bytes). > > > > > > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx> > > --- Applied with the fixed commit log and merged into the new directory structure. Thanks Jesper! -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
