Search Linux Wireless

Re: [PATCH v2] cfg80211: fix BSS comparison

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-04-30 9:23 AM, Emmanuel Grumbach wrote:
> Since the BSS table is organized in a RB tree, the BSSs need to be
> comparable. This means that we must define a < and > operator to
> the BSS object.
> compare_ethr_addr isn't enough since it returns only a binary value.
> 
> Since Felix's
> 
> cfg80211: use compare_ether_addr on MAC addresses instead of memcmp
> 
>     Because of the constant size and guaranteed 16 bit alignment, the inline
>     compare_ether_addr function is much cheaper than calling memcmp.
> 
>     Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
>     Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> 
> The BSS table is corrupted: rb_find_bss can't find the bss.
> As a result BSSes are duplicated in the BSS table, and we get stuck
> while probing an AP before associating (in STA mode).
> 
> Change-Id: I85928756f4328028230832c1565ece7f412f3843
> CC: Felix Fietkau <nbd@xxxxxxxxxxx>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
Looks good, thanks for finding this.
Acked-by: Felix Fietkau <nbd@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux