On Mon, Apr 23, 2012 at 10:50 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2012-04-23 at 19:36 -0700, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxx> >> >> pr_fmt() is either defined or we redefine it. Typically >> drivers define it prior to including printk.h but this >> is done under the assumption that no other subsystem >> it uses has already defined pr_fmt(). In such cases >> pr_fmt() should be undefined and redefined. >> >> Doing this properly shaves down compilation time quite >> considerably. > >> --- a/drivers/net/wireless/ath/ath5k/ani.c >> +++ b/drivers/net/wireless/ath/ath5k/ani.c >> @@ -14,8 +14,11 @@ >> * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. >> */ >> >> +#undef pr_fmt >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > I understand this is right for compat, but is it really also needed in > mainline? I've seen drivers do this, drivers/net/wireless/mwifiex/decl.h was where I got the hint of doing this actually. > I was under the impression there we never defined pr_fmt in > header files. I think this is a good assumption, but it can easily and sloppily hold to not be true. In fact, I'm thinking it may make sense to add a helper to do this uniformly across the kernel. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
