Search Linux Wireless

Re: [PATCH 3.4 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-04-23 at 10:45 +0200, Florian Fainelli wrote:

> >   	} else if (regaddr == SDIO_CCCR_ABORT) {
> > +		sdfunc = kzalloc(sizeof(struct sdio_func), GFP_KERNEL);
> 
> You are not catching a kzalloc() possible failure here.
> 
> > +		memcpy(sdfunc, sdiodev->func[0], sizeof(struct sdio_func));

and it should probably be kmemdup anyway?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux