On Sun, 2012-04-22 at 21:54 +0200, Felix Fietkau wrote: > On 2012-04-21 11:51 PM, Johannes Berg wrote: > > On Sat, 2012-04-21 at 23:42 +0200, Felix Fietkau wrote: > > > >> rcu_assign_pointer(vlansdata->u.vlan.sta, sta); > >> + new_4addr = true; > >> } > >> > >> + if (sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN && > >> + sta->sdata->u.vlan.sta) > >> + prev_4addr = true; > > > > Doesn't that have to be before the assignment or something, otherwise > > it's always just true unless it was moved back to the AP iface, but > > still true if it was just assigned to an AP_VLAN iface? > This is just before the 'sta->sdata = vlansdata;' line, so it should be > OK. Or am I missing something here? Ah, I guess I missed that. Or maybe I was thinking what I also said on IRC -- when you move a station out of the 4addr VLAN u.vlan.sta is never reset to NULL. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
