On Sat, 2012-04-21 at 23:51 +0200, Johannes Berg wrote: > On Sat, 2012-04-21 at 23:42 +0200, Felix Fietkau wrote: > > > rcu_assign_pointer(vlansdata->u.vlan.sta, sta); > > + new_4addr = true; > > } > > > > + if (sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN && > > + sta->sdata->u.vlan.sta) > > + prev_4addr = true; > > Doesn't that have to be before the assignment or something, otherwise > it's always just true unless it was moved back to the AP iface, but > still true if it was just assigned to an AP_VLAN iface? There also seems to be another existing bug, if the station is moved out of the VLAN interface then the u.vlan.sta isn't cleared. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html