Hi Luciano,
Am 16.04.2012 12:48, schrieb Dan Carpenter:
> Hello Mircea Gherzan,
>
> The patch 690142e98826: "wl12xx: fix DMA-API-related warnings" from
> Mar 17, 2012, leads to the following Smatch warning:
> drivers/net/wireless/ti/wlcore/cmd.c:126 wl1271_cmd_wait_for_event_or_timeout()
> error: no modifiers for allocation.
How would you prefer my fix for this issue: as a new version of the
original patch or as a separate new patch?
Thanks,
Mircea
> static void wl1271_boot_fw_version(struct wl1271 *wl)
> {
> - struct wl1271_static_data static_data;
> + struct wl1271_static_data *static_data;
>
> - wl1271_read(wl, wl->cmd_box_addr, &static_data, sizeof(static_data),
> + static_data = kmalloc(sizeof(*static_data), GFP_DMA);
> ^^^^^^^
> You can't use GFP_DMA by itself like that, it needs to ORed with
> GFP_KERNEL or GFP_ATOMIC or something like that:
>
> static_data = kmalloc(sizeof(*static_data), GFP_KERNEL | GFP_DMA);
>
> + if (!static_data) {
> + __WARN();
> + return;
>
> There are a couple other places in this patch which do the same thing.
> Could you fix it, please?
>
> regards,
> dan carpenter
>
--
Mircea
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
