> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> Report all defined sync_cause errors in debugfs
> to aid with debugging.
>
> Use a macro to print out the interrupts file contents
> to decrease code duplication.
Now, that the patch is in wireless-testing, I have noticed a minor problem with it.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
<...>
> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
> index aa1680a..fba99ef 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.h
> +++ b/drivers/net/wireless/ath/ath9k/hw.h
> @@ -965,6 +965,12 @@ bool ath9k_hw_check_alive(struct ath_hw *ah);
>
> bool ath9k_hw_setpower(struct ath_hw *ah, enum ath9k_power_mode mode);
>
> +#ifdef CONFIG_ATH9K_DEBUGFS
> +void ath9k_debug_sync_cause(struct ath_common *common, u32 sync_cause);
> +#else
> +static void ath9k_debug_sync_cause(struct ath_common *common, u32 sync_cause) {}
Due to a missing 'inline' keyword, this causes a bunch of warnings if
CONFIG_ATH9K_DEBUGFS is not enabled:
CC [M] drivers/net/wireless/ath/main.o
CC [M] drivers/net/wireless/ath/regd.o
CC [M] drivers/net/wireless/ath/hw.o
CC [M] drivers/net/wireless/ath/key.o
LD [M] drivers/net/wireless/ath/ath.o
CC [M] drivers/net/wireless/ath/ath9k/beacon.o
drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
defined but not used
CC [M] drivers/net/wireless/ath/ath9k/gpio.o
drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
defined but not used
CC [M] drivers/net/wireless/ath/ath9k/init.o
drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
defined but not used
CC [M] drivers/net/wireless/ath/ath9k/main.o
drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
defined but not used
CC [M] drivers/net/wireless/ath/ath9k/recv.o
-Gabor
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
