On Mon, Apr 16, 2012 at 10:42:07PM +0200, Arend van Spriel wrote: > >I've attempted to maintain the same high-level behavior that the > >brcmsmac internal regulatory support currently enforces. I find a couple > >of these to be questionable however, those being: the setting of the > >radio disable state based on whether or not there are any channels > >allowed by regulatory, and the handling of enabling/disabling OFDM. > >Perhaps you can comment on whether or not these actions are needed. > > Regarding questionable things, you mean the transmit mute or is > there another radio disable that I have not found yet. I only recall > that channel 14 (JP only) does not allow OFDM so it may be to > accommodate that. It may not be explicitly needed as mac80211 > provides the rate and/or modulation to use for the transmit frame. I'm referring to radio_disabled in struct brcms_pub, specifically to the setting and clearing of the WL_RADIO_COUNTRY_DISABLE bit in this field. Patch 5 in the series deals specifically with this functionality. Btw, I restored setting the transmit mute for passive channels in this series, which I had to remove in earlier versions of these changes. Your patch to enable tx after seeing a beacon fixed the issue I was seeing. > >So far these changes are testing well on a MacBook Air 4,1 with BCM43224 > >wireless. I'm now able to see and associate with my AP on channel 52, > >which was not possible previously. > > I will try to organize some regulatory testing over here with your patches. Great, thanks! Seth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
