2012.04.15. 3:59 keltezéssel, Sujith Manoharan írta: > Gabor Juhos wrote: >> The 'ath9k_hw_update_regulatory_maxpower' >> helper function has been introduced by >> commit a55f858852e4345d0a31af593c46738ca8614bff >> (ath9k_hw: Cleanup TX power calculation for AR9287). >> >> Updating of the max_power_level value has been moved >> into the helper function in that change, however the >> removed code from 'ath9k_hw_ar9287_set_txpower' has >> not been replaced with a call of the new helper >> function. >> >> Due to that missing call, retrieving tx power for 2x2 >> and 3x3 chainmask is not handled properly. During the >> calculation of the tx power for 2x2 and 3x3 chainmasks >> the values are reduced. Those reductions must be >> compensated during retrieving. >> >> Fix this by adding the missing call of the helper >> function. >> >> Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx> >> Cc: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath9k/eeprom_9287.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/eeprom_9287.c b/drivers/net/wireless/ath/ath9k/eeprom_9287.c >> index f272236..b34e8b2 100644 >> --- a/drivers/net/wireless/ath/ath9k/eeprom_9287.c >> +++ b/drivers/net/wireless/ath/ath9k/eeprom_9287.c >> @@ -824,6 +824,8 @@ static void ath9k_hw_ar9287_set_txpower(struct ath_hw *ah, >> regulatory->max_power_level = ratesArray[i]; >> } >> >> + ath9k_hw_update_regulatory_maxpower(ah); >> + > > Looks like I got confused between 4K-based cards and AR9287. > Thanks for catching this. > > Acked-by: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx> Thanks, I will resend this as a regular patch. -Gabor -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
