Search Linux Wireless

Re: [PATCH] ath9k: Don't delete key from hw if using sw-crypt.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/03/2012 06:16 AM, Felix Fietkau wrote:
On 2012-04-02 10:41 PM, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear<greearb@xxxxxxxxxxxxxxx>

This spams logs if we are using large numbers of stations,
for instance:

ath: wiphy0: keyreset: keycache entry 228 out of range
ath: wiphy0: keyreset: keycache entry 228 out of range

Signed-off-by: Ben Greear<greearb@xxxxxxxxxxxxxxx>
---
:100644 100644 917032a... 65e7281... M	drivers/net/wireless/ath/ath9k/main.c
  drivers/net/wireless/ath/ath9k/main.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 917032a..65e7281 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1771,6 +1771,9 @@ static void ath9k_del_ps_key(struct ath_softc *sc,
  	if (!an->ps_key)
  	    return;

+	if (ath9k_modparam_nohwcrypt)
+		return;
+
This looks wrong to me. ps_key is used for better powersave handling of
both unencrypted and encrypted stations (using the keycache only for tx
filtering on unencrypted stations).

Ok..should we just remove the spammy printk when the keycache entry
is out of range then?

THanks,
Ben


- Felix


--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux