Search Linux Wireless

Re: [PATCH 2/2] compat: explicitly export generated variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-03-30 at 13:30 -0700, Luis R. Rodriguez wrote:
> On Fri, Mar 30, 2012 at 4:11 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > Doing the blanket "export" statement at the beginning
> > of the generated file confuses the kernel's Makefiles
> > and causes extreme build slowdowns.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> > ---
> 
> Nice, how did you figure this out BTW!?

Random monkey approach ;-)

I noticed it was slow and saw that it was due to some weird shit from
the kernel Makefile.lib being executed when it shouldn't be.

Since I have the compat *result* in git, I could easily see the diff
between the old compat.git/compat-wireless.git and the new versions. And
then I basically tried to identify the changes that caused this problem,
my best guess was that it had to be the Makefile so I gradually changed
that back to the previous version until the problem went away ... and
then identified which changes were responsible.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux