On Fri, 2012-03-30 at 14:14 +0200, Arend van Spriel wrote: > On 03/30/2012 01:54 PM, Johannes Berg wrote: > > On Fri, 2012-03-30 at 13:49 +0200, Arend van Spriel wrote: > >> On 03/30/2012 01:13 PM, Johannes Berg wrote: > >>> > >>> +#ifdef pr_fmt > >>> +#undef pr_fmt > >>> +#endif > >>> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > >>> > >>> #include<linux/module.h> > >> > >> Trivial remark. Not really necessary to do the #ifdef. #undef works fine > >> if pr_fmt has not been defined. > > > > Really? I thought it would give a warning then, but couldn't test it > > since it was defined for me. > > > > johannes > > > > > > I made a little test program to confirm my thought, before sending my > previous email. Retried compiling with '-W -Wall -ansi -pedantic' and no > complaints about the #undef. Ok. I'm too lazy to send a new patch, but maybe Luis wants to change it when he applies it :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
