On Fri, 2012-03-30 at 10:07 +0530, Sujith Manoharan wrote: > Johannes Berg wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > The channel type argument to the rate_update() > > callback isn't really the correct way to give > > the rate control algorithm about the desired > > RX bandwidth of the peer. > > > > Remove this argument, and instead update the > > STA capabilities with 20/40 appropriately. The > > SMPS update done by this callback works in the > > same way, so this makes the callback cleaner. > > I think that the HT capabilities cannot be changed dynamically. > The HT operating parameters along with ChannelSwitch frames are used to > notify bandwidth changes. Or that is my understanding of 11.14.4.2. Yes, that's true. However, we use the sta.ht_cap field more of a current operating set database. For example, we also update it when the station changes SMPS configuration. Also, we never keep it at just the station's capabilities -- we always restrict it by our own TX capabilities (so if for example we aren't 40 MHz capable, we already don't leave 40 MHz in). Overall, I don't really see a problem with this. I suppose we could rename the field to make that a bit clearer, but I see little value in using some other struct or so? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
