On Thu, 2012-03-29 at 22:09 +0200, Eliad Peller wrote:
> > + if (WARN_ON(!sdata))
> > + return;
> > +
> ...
>
> > @@ -280,6 +339,8 @@ static int ieee80211_do_open(struct net_
> > break;
> > default:
> > if (coming_up) {
> > + ieee80211_del_virtual_monitor(local);
> > +
>
> i think this will always trigger the warning?
Yeah, somehow I didn't see this in my first round of testing. I
distinctly remember thinking "I need to remove the warning then" but
clearly never did :-)
> > - if (WARN_ON(sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||
> > - sdata->vif.type == NL80211_IFTYPE_MONITOR))
> > + if (WARN_ON(sdata->vif.type == NL80211_IFTYPE_AP_VLAN))
> > return -EINVAL;
> >
> maybe check for IEEE80211_HW_WANT_MONITOR_VIF instead?
Good point, should do that.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
