On Thu, 2012-03-29 at 21:13 +0200, Eliad Peller wrote:
> > *
> > + * @sta_rc_update: Notifies the driver of changes to the bitrates that can be
> > + * used to transmit to the station. The changes are advertised with bits
> > + * from &enum ieee80211_rate_control_changed and the values are reflected
> > + * in the station data. This callback should only be used when the driver
> > + * uses hardware rate control (%IEEE80211_HW_HAS_RATE_CONTROL) since
> > + * otherwise the rate control algorithm is notified directly.
> > + * Must be atomic.
> > + *
> it's either atomic...
>
> > +static inline void drv_sta_rc_update(struct ieee80211_local *local,
> > + struct ieee80211_sub_if_data *sdata,
> > + struct ieee80211_sta *sta, u32 changed)
> > +{
> > + might_sleep();
>
> or might sleep :)
Oh wow, it must be atomic since it's potentially in the RX path. I guess
the other path (the more common one) doesn't require atomic. Good catch,
thanks!
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
