On Thu, 2012-03-29 at 09:09 -0700, Ben Greear wrote: > On 03/28/2012 11:38 PM, Johannes Berg wrote: > > On Wed, 2012-03-28 at 12:45 -0700, Ben Greear wrote: > >> On 03/28/2012 12:13 PM, Johannes Berg wrote: > >>> On Wed, 2012-03-28 at 12:10 -0700, Ben Greear wrote: > >>>> On 03/28/2012 11:59 AM, Johannes Berg wrote: > >> > >>>>> Hm. Maybe this is the problem? > >>>>> > >>>>> http://p.sipsolutions.net/d432de678ae3ff17.txt > >>>> > >>>> I don't see any code that matches that in 3.3.0 (nothing with nl80211_start_ap, for instance) > >>> > >>> ah, well, it's set_beacon there or so > >>> > >>> johannes > >> > >> > >> I tried this patch, but it still spews (see below) > > > >> WARNING: at /home/greearb/git/linux-3.3.dev.y/net/mac80211/driver-ops.h:12 check_sdata_in_driver+0x26/0x2b [mac80211]() > > > >> [<c04263d1>] warn_slowpath_common+0x65/0x7a > >> [<f96a28d1>] ? check_sdata_in_driver+0x26/0x2b [mac80211] > >> [<c042644a>] warn_slowpath_fmt+0x26/0x2a > >> [<f96a28d1>] check_sdata_in_driver+0x26/0x2b [mac80211] > >> [<f96a3438>] ieee80211_set_txq_params+0x97/0xec [mac80211] > > > > but now it's coming from elsewhere, see this patch? > > > > http://p.sipsolutions.net/b8506c9d7ce8a119.txt > > That fixes the problem for me, or at least the easily-reproducible part. > > I did have to modify the patch to work on 3.3.0 since it has no start_ap > and the beacon method is named a bit differently. > > I'm going to apply this to my patch set and will let you know if > I see anything else strange. Ok, I'll send all of this upstream too. I'll add Cc: stable, and when I need a patch to apply to stable I might ask you for yours then :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html