On Wed, 2012-03-28 at 11:28 +0200, Timo Lindhorst wrote:
> Hey,
>
> > + if (!ack)
> > + for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> > + tx_count[i] = txi->control.rates[i].count;
> > +
> > ieee80211_tx_info_clear_status(txi);
> > if (!(txi->flags & IEEE80211_TX_CTL_NO_ACK) && ack)
> > txi->flags |= IEEE80211_TX_STAT_ACK;
> > +
> > + if (ack) {
> > + txi->status.rates[0].count = 1;
> > + txi->status.rates[1].idx = -1;
> > + } else {
> > + for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> > + txi->control.rates[i].count = tx_count[i];
> > + }
> > +
> > ieee80211_tx_status_irqsafe(hw, skb);
> > }
>
> I know: backing up the count values, clearing the status, and restoring the
> values if necessary is kind of ugly. Would it be better to partly clear the
> status manually instead of using ieee80211_tx_info_clear_status() ?
Yeah just noticed the ieee80211_tx_info_clear_status() in there too...
OTOH, what are you using this for? It seems almost like we should always
just set
txi->status.rates[0].count = 1;
since we never attempted multiple transmits? I'm not really sure though,
it's a corner case ... I could also imagine this being populated by
userspace (wmediumd) but I guess that isn't there now ...
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
