Johannes Berg wrote:
On Tue, 2012-03-27 at 15:55 +0200, Michal Kazior wrote:-u32 ieee80211_sta_get_rates(struct ieee80211_local *local, +u32 ieee80211_sta_get_rates(struct ieee80211_sub_if_data *sdata, struct ieee802_11_elems *elems, enum ieee80211_band band) { + struct ieee80211_local *local = sdata->local; struct ieee80211_supported_band *sband; struct ieee80211_rate *bitrates; size_t num_rates;Ditto here, though I actually got confused even further ... we shouldn't remove the local/sdata arguments, we should only remove the use of local->hw.conf.channel! IOW simply something like this: - if (!sband) { - WARN_ON(1); - sband = local->hw.wiphy->bands[local->hw.conf.channel->band]; - } + if (WARN_ON(!sband)) + return 1; should be sufficient instead of doing all the prototype changes?
You're right. I'll resend a new patchset. -- Pozdrawiam / Best regards, Michal Kazior. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
