Search Linux Wireless

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 27, 2012 at 8:28 AM, Chen, Chien-Chia <machen@xxxxxxxx> wrote:
> Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
> It fixes of starting rfkill_poll function at the right time if
> sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
> be starting before bringing up the wireless interface.

Looks reasonable to me. However, you should include John Linville in future
patch submissions (if your intention is to get them merged :D and not only
reviewed).

Acked-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>

> Signed-off-by: Kevin Chou <kevin.chou@xxxxxxxxxxxx>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index fc9901e..90cc5e7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1062,11 +1062,6 @@ static int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev)
>
>        set_bit(DEVICE_STATE_INITIALIZED, &rt2x00dev->flags);
>
> -       /*
> -        * Register the extra components.
> -        */
> -       rt2x00rfkill_register(rt2x00dev);
> -
>        return 0;
>  }
>
> @@ -1210,6 +1205,7 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
>        rt2x00link_register(rt2x00dev);
>        rt2x00leds_register(rt2x00dev);
>        rt2x00debug_register(rt2x00dev);
> +       rt2x00rfkill_register(rt2x00dev);
>
>        return 0;
>
> --
> 1.7.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux