On Mon, 2012-03-26 at 20:53 +0530, Rajkumar Manoharan wrote:
> The station has to inform the offchannel status to the assiociated AP
> while switching b/w oper and off-channel. The station uses pspoll to
Gee, ok, I thought you meant "bandwidth", not "between". Might be worth
not being so lazy in the commit log ...
> fetch the buffered data from the AP and the pspoll frame can only be
> used when the powersave is enabled. For non-PS case, the station has
> to use nullfunc frame notification. Fix that.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx>
> ---
> net/mac80211/offchannel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c
> index f054e94..f7aedfc 100644
> --- a/net/mac80211/offchannel.c
> +++ b/net/mac80211/offchannel.c
> @@ -129,7 +129,7 @@ void ieee80211_offchannel_stop_vifs(struct ieee80211_local *local,
>
> if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
> netif_tx_stop_all_queues(sdata->dev);
> - if (offchannel_ps_enable &&
> + if ((offchannel_ps_enable || !sdata->u.mgd.powersave) &&
I'm not sure I like evaluating u.mgd.powersave before we even know it's
a managed interface ... not a huge issue though.
> (sdata->vif.type == NL80211_IFTYPE_STATION) &&
> sdata->u.mgd.associated)
> ieee80211_offchannel_ps_enable(sdata, true);
> @@ -152,7 +152,7 @@ void ieee80211_offchannel_return(struct ieee80211_local *local,
> continue;
>
> /* Tell AP we're back */
> - if (offchannel_ps_disable &&
> + if ((offchannel_ps_disable || !sdata->u.mgd.powersave) &&
> sdata->vif.type == NL80211_IFTYPE_STATION) {
> if (sdata->u.mgd.associated)
> ieee80211_offchannel_ps_disable(sdata);
Overall though I don't get it. u.mgd.powersave has nothing to do with
the current powersave state at all, it's just whether cfg80211 requested
powersave mode or not -- so NACK.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
